what is the error with the code??

The problem is that you're trying to modify a constant string and so are getting an access violation.

If you use a char array rather than char * then the compiler should treat is as a modifiable string and it should then work OK.

I've also made another change in the reverse() function as, at present, you're reversing the first 8 characters of the second string, not the first 7:

#include

using namespace std;

void reverse(char str[], int count = 0);

int main()

{

char s1[] = "This is a test.";

char s2[] = "I like C++.";

reverse(s1); // reverse entire string

reverse(s2, 7); // reverse 1st 7 chars

cout << s1 << '\n';

cout << s2 << '\n';

return 0;

}

void reverse(char str[], int count)

{

int i, j;

char temp;

if(!count) count = strlen(str); // not now subtracting 1

for(i=0, j=count -1; i

temp = str[i];

str[i] = str[j];

str[j] = temp;

}

1 Reply

Know the answer? Post it — somebody with the same question will find it here.

Vulpes13y ago
The problem is that you're trying to modify a constant string and so are getting an access violation.

If you use a char array rather than char * then the compiler should treat is as a modifiable string and it should then work OK.

I've also made another change in the reverse() function as, at present, you're reversing the first 8 characters of the second string, not the first 7:

#include
#include
using namespace std;

void reverse(char str[], int count = 0);

int main()
{
char s1[] = "This is a test.";
char s2[] = "I like C++.";

reverse(s1); // reverse entire string
reverse(s2, 7); // reverse 1st 7 chars

cout << s1 << '\n';
cout << s2 << '\n';

return 0;
}

void reverse(char str[], int count)
{
int i, j;
char temp;

if(!count) count = strlen(str); // not now subtracting 1

for(i=0, j=count -1; i
temp = str[i];
str[i] = str[j];
str[j] = temp;
}
}
0