VS2008 C# 'Foreach' control selection problem

Sam

Hello,

I am trying to test a checkbox state by selecting it by its Tag.
Problem is that although the program specifically selects only Check boxes,
it will not recognize the control as a checkbox, and thus will not accept the 'Checked' property that is normal for CheckBoxes.
IMHO This seems liek a VS ignored feature.
Can anyone advice on a workaround or another way to get the same result?
foreach (Control chkbx in Controls)
{
if (chkbx.GetType() == typeof(CheckBox))
{
if (chkbx.Tag == NumUpDn3.Tag && chkbx.Checked) << This 'Checked' not accepted!!
{ do something }
}
}

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes14y ago
Accepted answer
Just a wild guess but the problem you still have may be caused by the CheckBoxes being placed on some other container such as a panel or groupbox rather than the form itself.

If so, then you either need to iterate through the controls collection for that container or do a recursive search for the checkboxes.
0
Sam14y ago
Vulpes, you got yourself another positive point.

Yes, you are right. I figured out that the problem was that my check boxes were all part of group boxes.
I moved them out, and it works as expected.
The only problem was that I wanted them inside the frame of the group.

I solved it with by nested foreach: find first the group boxes and then find the check boxes within each group box.

foreach (Control gb in Controls)

                if (gb is GroupBox)
                {
                    GroupBox grpbx = (GroupBox)gb;

                    foreach (Control c in grpbx.Controls)
                    {
                        if (c is CheckBox)
                        {
                            CheckBox chkbx = (CheckBox)c;
                            if (chkbx.Tag == numUpDn.Tag && chkbx.Checked)
                            {
                                textboxOut.Text = chkbx.Name;
                                calibration_mode = 3;
                            }
                        }
                    }
0
Sam14y ago
Thanks Vulpes,
This solved the 'Checked' issue, and I beleive I understand what you did (Separating the foreach and then Casting c to CheckBox?).

I still have another issue that the foreach iterates and stops after the first foundchaeckbox item.
I'll keep working, but you solved the issue I asked about.
Thanks.
0
Vulpes14y ago
Try:

foreach (Control c in Controls)
{
if (chkbx is CheckBox)
{
CheckBox chkbx = (CheckBox)c;
if (chkbx.Tag == NumUpDn3.Tag && chkbx.Checked)
{
// do something
}
}
}
0