return multiple values in public string method

Either change the return type to class type which is good and i will recommend (Note:- Email can never be duplicated so you should always get one result and not a List , so either your business logic is wrong or you are in wrong track)

other is to construct a string and send a single string .

method 1.

public login Post(login lg)
{
try {
string query = @"select email,upassword,status,userid from signup where email='" + lg.email + "' and upassword='" + lg.upassword + "' and status=1";
DataTable dt = null;
using(SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["rhymeDB"].ConnectionString))
using(SqlCommand cmd = new SqlCommand(query, con))
using (SqlDataAdapter da = new SqlDataAdapter(cmd))
{
DataSet ds = new DataSet();
da.Fill(ds);
if (ds.Tables.Count > 0)
{
dt = ds.Tables[0];
}
if (dt.Rows.Count > 0)
{
login lgg = new login();
lgg.email = dt.Rows[0]["email"].ToString();
lgg.userid = dt.Rows[0]["userid"].ToString();
return lgg;
}
else
{
return null;
}
}
}
catch(Exception ex)
{
return null;
}
}

And in the view/ aspx you can iterate through individual object

@item.Email
@item.Password
@item.Status

Method 2.

public string Post(login lg)
{
try {
string query = @"select email,upassword,status,userid from signup where email='" + lg.email + "' and upassword='" + lg.upassword + "' and status=1";
DataTable dt = null;
using(SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["rhymeDB"].ConnectionString))
using(SqlCommand cmd = new SqlCommand(query, con))
using (SqlDataAdapter da = new SqlDataAdapter(cmd))
{
DataSet ds = new DataSet();
da.Fill(ds);
if (ds.Tables.Count > 0)
{
dt = ds.Tables[0];
}
if (dt.Rows.Count > 0)
{
login lgg = new login();
lgg.email = dt.Rows[0]["email"].ToString();
lgg.userid = dt.Rows[0]["userid"].ToString();
string res= email+userid;
return res;
}
else
{
return "invalid";
}
}
}
catch(Exception ex)
{
return ex.ToString();
}
}

According to me both method are wrong as they are not fullfilling the Rest principles, so better is to create method as

Note:- your method id Get and Not Post. (you are fetching data not posting data.)

public HttpResponseMessage GetUser(Login lg)
{
try
{
string query = @"select email,upassword,status,userid from signup where email='" + lg.email + "' and upassword='" + lg.upassword + "' and status=1";
DataTable dt = null;
using(SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["rhymeDB"].ConnectionString))
using(SqlCommand cmd = new SqlCommand(query, con))
using (SqlDataAdapter da = new SqlDataAdapter(cmd))
{
DataSet ds = new DataSet();
da.Fill(ds);
if (ds.Tables.Count > 0)
{
dt = ds.Tables[0];
}
if (dt.Rows.Count > 0)
{
login lgg = new login();
lgg.email = dt.Rows[0]["email"].ToString();
lgg.userid = dt.Rows[0]["userid"].ToString();
return Request.CreateResponse(HttpStatusCode.OK,lgg );
}
return Request.CreateErrorResponse(HttpStatusCode.NotFound,"No result found");
}
}
catch{
return new HttpResponseMessage(HttpStatusCode.InternalServerError);
}
}

2 Replies

Know the answer? Post it — somebody with the same question will find it here.

Sachin Singh5y ago
Accepted answer
Either change the return type to class type which is good and i will recommend (Note:- Email can never be duplicated so you should always get one result and not a List , so either your business logic is wrong or you are in wrong track)
other is to construct a string and send a single string .
method 1.
public login Post(login lg)
{

try {
string query = @"select email,upassword,status,userid from signup where email='" + lg.email + "' and upassword='" + lg.upassword + "' and status=1";
DataTable dt = null;
using(SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["rhymeDB"].ConnectionString))
using(SqlCommand cmd = new SqlCommand(query, con))
using (SqlDataAdapter da = new SqlDataAdapter(cmd))
{
DataSet ds = new DataSet();
da.Fill(ds);
if (ds.Tables.Count > 0)
{
dt = ds.Tables[0];
}
if (dt.Rows.Count > 0)
{
login lgg = new login();
lgg.email = dt.Rows[0]["email"].ToString();
lgg.userid = dt.Rows[0]["userid"].ToString();

return lgg;
}
else
{
return null;
}
}
}
catch(Exception ex)
{
return null;
}
}
And in the view/ aspx you can iterate through individual object
  @item.Email
   @item.Password
@item.Status
Method 2.
public string Post(login lg)
{

try {
string query = @"select email,upassword,status,userid from signup where email='" + lg.email + "' and upassword='" + lg.upassword + "' and status=1";
DataTable dt = null;
using(SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["rhymeDB"].ConnectionString))
using(SqlCommand cmd = new SqlCommand(query, con))
using (SqlDataAdapter da = new SqlDataAdapter(cmd))
{
DataSet ds = new DataSet();
da.Fill(ds);
if (ds.Tables.Count > 0)
{
dt = ds.Tables[0];
}
if (dt.Rows.Count > 0)
{
login lgg = new login();
lgg.email = dt.Rows[0]["email"].ToString();
lgg.userid = dt.Rows[0]["userid"].ToString();
string res= email+userid;
return res;
}
else
{
return "invalid";
}
}
}
catch(Exception ex)
{
return ex.ToString();
}
}
According to me both method are wrong as they are not fullfilling the Rest principles, so better is to create method as
Note:- your method id Get and Not Post. (you are fetching data not posting data.)
public HttpResponseMessage GetUser(Login lg)
        {
            try
            {
    string query = @"select email,upassword,status,userid from signup where email='" + lg.email + "' and upassword='" + lg.upassword + "' and status=1";
    DataTable dt = null;
    using(SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["rhymeDB"].ConnectionString))
    using(SqlCommand cmd = new SqlCommand(query, con))
    using (SqlDataAdapter da = new SqlDataAdapter(cmd))
    {
    DataSet ds = new DataSet();
    da.Fill(ds);
    if (ds.Tables.Count > 0)
    {
    dt = ds.Tables[0];
    }
    if (dt.Rows.Count > 0)
    {
    login lgg = new login();
    lgg.email = dt.Rows[0]["email"].ToString();
    lgg.userid = dt.Rows[0]["userid"].ToString();


     return Request.CreateResponse(HttpStatusCode.OK,lgg );

    }

return Request.CreateErrorResponse(HttpStatusCode.NotFound,"No result found");
           }
            }
            catch{
                return new HttpResponseMessage(HttpStatusCode.InternalServerError);
            }

        }
+3
Rijwan Ansari5y ago
You can convert into Json string as shown
// convert to Json string by seralization of the instance of class.
     string stringjson = JsonConvert.SerializeObject(log);
     return stringjson;
+1