query about same login page for both users

umair mohsin

this is my code.

public async Task Login(LoginViewModel model, string returnUrl)
{
    email = model.Email;
    if (!ModelState.IsValid)
    {
        return View(model);  
    }
    var result = await SignInManager.PasswordSignInAsync(model.Email, model.Password, model.RememberMe, shouldLockout: false);
    switch (result)
    {
        case SignInStatus.Success:
            return RedirectToLocal(returnUrl);
        case SignInStatus.LockedOut:
            return View("Lockout");
        case SignInStatus.RequiresVerification:
            return RedirectToAction("SendCode", new { ReturnUrl = returnUrl, RememberMe = model.RememberMe });
        case SignInStatus.Failure:
        default:
            return View(model);
    }
}

as above code shows i am using identity api in mvc,what i want to do i have created a single login page for both the users and i am checking user roles and redirecting them to the appropriate view like this:

private ActionResult RedirectToLocal(string returnUrl)
{
 
    var data=new  object();

    if (User.Identity.IsAuthenticated)
    {
        try
        {
            if (User.IsInRole("emp"))
            {
                data = empcontext.GetModel().
                    Where(x => x.Email == email).Select(x => x.Email).
                    FirstOrDefault();
                return RedirectToAction("Index", "Employer", data);

            }
            else if (User.IsInRole("can"))
            {
                data = context.GetModel().
                      Where(x => x.Email == email).
                      Select(x => x.Email).
                      FirstOrDefault();
                return RedirectToAction("Index", "Js", data);
            }

            else (Url.IsLocalUrl(returnUrl))
            {
                return Redirect(returnUrl);
            }
        }
        catch (Exception ex) { }
    }
}

above code gives squiggly red line the error says

'AccountController.RedirectToLocal(string)': not all code paths return a value

redirectto localis necessary to redirect the user to the same page if the user is not logged in

2 Replies

Know the answer? Post it — somebody with the same question will find it here.

umair mohsin2y ago
thanks for you quick reply dear but

initial if block is not working which is

if (User.Identity.IsAuthenticated)
{}

logically it is right because the user is not authenticated yet.do you have any idea how to handle this
0
Naimish Makwana2y ago
The error message 'AccountController.RedirectToLocal(string)': not all code paths return a value is indicating that there are some scenarios where your RedirectToLocal method does not return a value. In C#, all code paths in a method must return a value if the method’s return type is not void.

In your RedirectToLocal method, if User.Identity.IsAuthenticated is false, then the method does not return anything. Similarly, if User.Identity.IsAuthenticated is true but the user is not in the role “emp” or “can”, and Url.IsLocalUrl(returnUrl) is false, then the method also does not return anything.

To fix this, you should add a default return statement at the end of your method. Here’s an example:
```
private ActionResult RedirectToLocal(string returnUrl)
{
    var data = new object();

    if (User.Identity.IsAuthenticated)
    {
        try
        {
            if (User.IsInRole("emp"))
            {
                data = empcontext.GetModel().
                    Where(x => x.Email == email).Select(x => x.Email).
                    FirstOrDefault();
                return RedirectToAction("Index", "Employer", data);
            }
            else if (User.IsInRole("can"))
            {
                data = context.GetModel().
                    Where(x => x.Email == email).
                    Select(x => x.Email).
                    FirstOrDefault();
                return RedirectToAction("Index", "Js", data);
            }
            else if (Url.IsLocalUrl(returnUrl))
            {
                return Redirect(returnUrl);
            }
        }
        catch (Exception ex) { }
    }

    // Add a default return statement here
    return RedirectToAction("Index", "Home");
}
```
In this example, if none of the conditions are met, the method will redirect the user to the Home Index page. You can replace "Index", "Home" with the appropriate action and controller for your application. This ensures that all code paths in the method return a value, which should resolve the error. Please replace "Index", "Home" with the appropriate action and controller for your application. This ensures that all code paths in the method return a value, which should resolve the error. Remember to handle exceptions properly in your production code. The empty catch block is just for demonstration purposes. It’s generally a good practice to at least log the exception, or handle it in a way that’s appropriate for your specific application.

Thanks
0