Login page issue

umair mohsin

here is my complete code.i am basically making a login page in which a user which is not registered should given a detailed message and those who are registered should send to their profile page i didn't get the idea how to play this game although i am trying alot for this and logically my code is correct but still not working please help me out in it.

string constr = ConfigurationManager.ConnectionStrings["JPConstr"].ConnectionString;

using (SqlConnection conn = new SqlConnection(constr))

{

conn.Open();

SqlCommand cmd = new SqlCommand("select UserId,Password from Sign_Up where UserId=@Id", conn);

cmd.Parameters.AddWithValue("@Id", txtlogin.Text);

SqlDataReader rdr = cmd.ExecuteReader();

while (rdr.Read())

{

string User = rdr["UserId"].ToString();

string password = rdr["Password"].ToString();

if (password == txtpassword.Text)

{

Page.Session.Add("user", txtlogin.Text);

Page.Session.Timeout = 20;

Response.Redirect("Profile.aspx?id=success");

}

else if (txtlogin.Text!=User && txtpassword.Text != password)

{

Label3.Text = "Invalid user id or password";

Label3.ForeColor = System.Drawing.Color.Blue;

}

//if (txtlogin.Text!=UserId)

//{

// Label3.Text = "crazy password or user id";

// Label3.ForeColor = System.Drawing.Color.Purple;

//}

else

{

Label3.Text = "Invalid user id or password login with valid account or sign up to register";

Label3.ForeColor = System.Drawing.Color.Red;

}

conn.Close();

5 Replies

Know the answer? Post it — somebody with the same question will find it here.

Karthi Keyan9y ago
Accepted answer
Hi umair,

Why you are maintaining this both function's insteadof one.

else if (txtlogin.Text!=User && txtpassword.Text != password)
{
Label3.Text = "Invalid user id or password";
Label3.ForeColor = System.Drawing.Color.Blue;
}
else
{
Label3.Text = "Invalid user id or password login with valid account or sign up to register";
Label3.ForeColor = System.Drawing.Color.Red;
}

try this.

else if (txtlogin.Text!=User || txtpassword.Text != password)
{
Label3.Text = "Invalid user id or password login with valid account or sign up to register";
Label3.ForeColor = System.Drawing.Color.Red;
}

This will work fine. and why don't you check the password in the Database itself by passing that also in the query. select the data if that exists with given userid and password. you don't need to check the password in the front end.

SqlCommand cmd = new SqlCommand("select UserId,Password from Sign_Up where UserId=@Id and Password = @password", conn);
cmd.Parameters.AddWithValue("@Id", txtlogin.Text);
cmd.Parameters.AddWithValue("@password", txtpassword.Text);

+1
Karthi Keyan9y ago
@umair,

Try this,

string constr = ConfigurationManager.ConnectionStrings["JPConstr"].ConnectionString;

Public void checklogin()
{
    DataTable dt1 = filldata();

if(dt1.Rows.Count() > 0)
    {
         //use this if you allow many user can have the same username but diff passwords. so use foreach.

           int i = 0;
           foreach(DataRow dr in dt1.Rows)
           {
              if(txtpass.Text = dr["password"].ToString())
              {
                  i++;
               }
            }

           if(i > 0)
              //do what you want if password match.
           else
           {
               //invalid password message box.
            }

        //if you not allow same user name with diff password. I mean the username should not match with any other user name. use this.

          string pass = " ";
         foreach(DataRow dr in dt1.Rows)
        {
              pass = dr["Password"].ToString();
         }

        if(txtpass.Text == pass)
         {
              //do what you want if password match.
         }
        else
           {
                //invalid password message box.
            }
    }
    else
     {
        //if the user not Registered the dt1.Rows must be 0.

         Label3.Text = "It seems you are not registered or you Entered the Wrong User Name";
          Label3.ForeColor = System.Drawing.Color.Blue;
      }
}

Public DataTable filldata()
{
SqlConnection conn = new SqlConnection(constr)
SqlCommand cmd = new SqlCommand("select UserId,Password from Sign_Up where UserId=@Id", conn);
cmd.Parameters.AddWithValue("@Id", txtlogin.Text);
conn.Open();
DataTable dt = new DataTable();
SqlDataAdapter da =new SqlDataAdapter(cmd);
da.Fill(dt);
conn.Close();
return dt;
}

i hope this will help you.
+1
umair mohsin9y ago
string constr1 = ConfigurationManager.ConnectionStrings["JPConstr"].ConnectionString;
using (SqlConnection conn = new SqlConnection(constr1))
{
conn.Open();
SqlCommand cmd = new SqlCommand("select UserId,Password from Sign_Up", conn);
SqlDataReader rdr = cmd.ExecuteReader();
while (rdr.Read())
{
string User = rdr["UserId"].ToString();
string Pass = rdr["Password"].ToString();

if (txtlogin.Text!=User)
{
Label3.Text = "It seems you are not registered to us";
Label3.ForeColor = System.Drawing.Color.Blue;
}
else if(txtpassword.Text != Pass)
{
Label3.Text = "Invalid user Id Or Password";
Label3.ForeColor = System.Drawing.Color.Purple;

}

}
conn.Close();
}

this is the simplest code which should work but not working according to if block unauthorized user should warn and according to else if block if user enters incorrect password but his/her id is right this code block should work i also place above true condition in else if block but not worked.

i don't know what the hack is this.could you suggest karthi what should i do
+1
umair mohsin9y ago
this thing is fine which you told karthi-keyan174 but i want my application:

(a)to dispaly a message to unregistered people that they are not registered.
(b)if by mistake user enters wrong password the message should be wrong email id or password

to accomplish a i had to make changes to my query.
b is working fine according to logic i got that thing.

i tried this code
+1

Bryian Tan9y ago

I would suggest to replace the while loop with the following.

if (rdr.Read())
{
//that mean user in the database
//do the authentiation (check password)
//if password match redirect to Profile.aspx?id=success page
//else error Invalid user id or password
}
else
{
//user not in the database
//display message Invalid user id or password login with valid account or sign up to register
}