List saving only last record-duplicates

A Repasky

When I Add a record to a List it only keeps the last record from the datareader. What am I doing wrong? I thought initially that it was the datareader.

I still do not know what to do. Do I need to store in another List?

This not working.

holdRow.Add(det);

Thanks for the help.
arep

2 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes13y ago
Accepted answer
It appears that you're adding the same 'det' object to the list each time you read a new record.

I'd try moving this line:

DetailRecord det = new DetailRecord();

within the while loop so you create a new object for each read:

while (dr.Read())
{
if (recnt == 0)
{
for (int fcnt = 0; fcnt < dr.FieldCount; fcnt++)
{
header.Add(dr.GetName(fcnt));
}
GenXML.AddWS_Headerdata(out ws1, out sd1, header); //Write header row
}

DetailRecord det = new DetailRecord();
det.PHARMACY_CLAIM_NBR = dr["PHARMACY_CLAIM_NBR"].ToString();
Output_Files.PrintLog("IN=" + det.PHARMACY_CLAIM_NBR);

holdRow.Add(det);
recnt++;
}
0
A Repasky13y ago
Thanks, that fixed the problem.
arep
0