Iterating throw every mail in Outlook

michal adamkiewiczm

Hi Guys,

The idea is that I must only iterate for every mail in Outlook 2007 inbox folder, and those mail which passed my conditions, I must moved to subfoler named "Archive". This is only a few lines of code, but even with this a have problem:(, and the worst thing is that I need this to my work for tommorrow. My code work fine.....but only for 1 mail...and I dont't know why? For example I sent to my e-mail account set up in Outlook 3 mails which are consistend with my conditions (for example every 3 mails have no subject and they have only 1 attachment), and run my application in VS 2008, then I look in Outlook and I see that only one of those three mails have been moved, If I run app, next mail will be moved to Archive subfolder, and like that....I don't know why he don't do this at once as I iterate using foreach? It's not logical for me:(

This is my very small code:

Microsoft.Office.Interop.Outlook.Application outlook = new Microsoft.Office.Interop.Outlook.Application();
            Microsoft.Office.Interop.Outlook.NameSpace names = outlook.GetNamespace("MAPI");
            Microsoft.Office.Interop.Outlook.MAPIFolder odbiorcza = names.GetDefaultFolder(OlDefaultFolders.olFolderInbox);
            Microsoft.Office.Interop.Outlook.MAPIFolder archive = names.GetDefaultFolder(OlDefaultFolders.olFolderInbox).Folders["Archive"];


                if (odbiorcza.Items.Count > 0)
                {
                    foreach (Microsoft.Office.Interop.Outlook.MailItem mail in odbiorcza.Items)
                    {
                        if (mail.Subject == null || mail.Subject.StartsWith("WWY"))
                        {
                            MessageBox.Show(mail.SenderName.ToString());

                            if (mail.Attachments.Count == 1)
                            {
                                mail.Move(archive);
                            }
                        }
                    }

                }

I would be very gratefully for every advice and tip, really!
And sorry for my language, but I'm just learning english

Best Greets
Michael

7 Replies

Know the answer? Post it — somebody with the same question will find it here.

Piotr14y ago
Hej Michal,

If you are sure there is no your code waiting for input you may just call for keypressed event, or try close console.

Regards
Piotr
0
michal adamkiewiczm14y ago
I don't really now which metod triggers this warning, but I suppose that it's this Move as You said, but In the time, I found some Add In for Oulook called "Advanced Security Outlook" which give a feature for allow some external applications to access Outlook personal information not only for example for 10 minutes as "oryginal" Outlook warning message allowed but for "all the time", so it's solved my problem:), but as in life, there appeared the next ( I hope the last one in my short way to provide this small code application), As You resolved my problem with code, next I found solution for warning pop-up in Outlook, the last thing is...I re-writed code to the project type - console application (becouse, it will be "fired" from another code...in VBA), and the last worst thing is that after everythings done, e-mail have been moved, but the console window unfortunatelly doesn't dissapear (it's still showing the system windows with the texts: "Press any key...."), and this is my last nightmare;P, I now that it's pretty silly, but unfortunatelly this code must by fully automaticly, and only "run" in background, and don't show anything
0
Vulpes14y ago
I think that the reason why it wasn't working before is that when you called the Move method it was changing the odbiorcza.Items collection and messing up the iteration.

You could have got around this by using a 'for' rather than a 'foreach' loop and iterating backwards through the collection but, if the code's working now, I wouldn't alter it.

Which method are you calling when the warning message pops up - is it the Move method?
0
michal adamkiewiczm14y ago
Ooo man, Vulpes, now It's working, thanks a lot man, I'm really really appreciated, I don't know what is a diffrence for Move Method in Outlook for using a list with selected items, or iterating for a "crude" mails, but the most importing thing is that it's works now:) thanks.

Only one little thing now is, that I cant resolve a problem with the warning message generated from Outlook that, some program want to acces to your personal informations etc....If I click allow everythink is oki, but the those few lines of code which You helped me, will be runned from macro in Access VBA, so It must be automaticly in 100%, that why this warning message crossed a bit my plans:(
0
Vulpes14y ago
That was exactly what I meant (mail.Subject == "") so, if that doesn't work either, then I don't know what the problem could be.

I'd make sure that the code is actually finding three mails which meet the conditions by storing them first in a List, If it is, then the problem must lie with the mail.Move method:

var mailList = new List();

if (odbiorcza.Items.Count > 0)
{
foreach (Microsoft.Office.Interop.Outlook.MailItem mail in odbiorcza.Items)
{
if (String.IsNullOrEmpty(mail.Subject) || mail.Subject.StartsWith("WWY"))
{
MessageBox.Show(mail.SenderName.ToString());

if (mail.Attachments.Count == 1)
{
mailList.Add(mail);
}
}
}
}

MessageBox.Show("There are " + mailList.Count.ToString() + " mails which satisfy the conditions");

foreach(Microsoft.Office.Interop.Outlook.MailItem mail in mailList)
{
mail.Move(archive);
}
0
michal adamkiewiczm14y ago
Hmm what do You mean, becouse I don't understand idea (yeap, this is my english unfortunatelly:( ), I tried using mail.Subcject == "" too, and it's too doesn't work
0
Vulpes14y ago
Is it possible that mail.Subject could be an empty string rather than null for 2 of the 3 mails?
0