Iterating through an array using ForEach

Nigel Foster

Hello. Brilliant forum by the way. Why doesn't this work please?

public void InitializePack()
{
Card [] pack=new Card[52];
for (int i = 0; i < 4; i++) {
for (int j = 1; j < 14; j++) {
pack[(i*13)+j-1] = new Card((Suits)i, (Values)j);
}
}
foreach (Card c in pack)
Console.WriteLine(c.Name);
}

c is null at first iteration. I have only seen examples of foreach iterating through arrays whose elements are defined at declaration using {}. Is this the issue?

I've not included the rest of the code as I thought you'd see this one straight away.

Thanks very much!

5 Replies

Know the answer? Post it — somebody with the same question will find it here.

Dharmraj Thakur8y ago
I implement your code... its working fine, Where is the issue?
class Card
{
    public Card(Suits suit, Values value)  // This constructor has integer values sent to it
    {
        this.Suit = suit;
        this.Value = value;
    }

    public Suits Suit { get; set; }
    public Values Value { get; set; }

    public string Name
    {
        get
        {
            //return Value.ToString() + " of " + Suit.ToString();  // The integer values can be converted to their reference names
            return (Values)Value + " of " + (Suits)Suit;  // Here's another way of doing it - Casting to their type, not to string
        }
    }
}

enum Suits
{
    Hearts,     // 0         'Hearts' is of type Suits
    Clubs,      // 1
    Diamonds,   // 2
    Spades      // 3
}

enum Values
{
    Ace = 1,                // 'Ace' is of type Values
    Two = 2,
    Three = 3,
    Four = 4,
    Five = 5,
    Six = 6,
    Seven = 7,
    Eight = 8,
    Nine = 9,
    Ten = 10,
    Jack = 11,
    Queen = 12,
    King = 13
}

class Program
{
    static void Main(string[] args)
    {
        InitializePack();
        Console.ReadKey();
    }
    public static void InitializePack()
    {
        Card[] pack = new Card[52];
        for (int i = 0; i < 4; i++)
        {
            for (int j = 1; j < 14; j++)
            {
                pack[(i * 13) + j - 1] = new Card((Suits)i, (Values)j);
            }
        }
        foreach (Card c in pack)
            Console.WriteLine(c.Name);
    }
}
+1
Nigel Foster8y ago
1. class Card
2. {
3. public Card(Suits suit, Values value) // This constructor has integer values sent to it
4. {
5. this.Suit = suit;
6. this.Value = value;
7. }
9. public Suits Suit { get; set; }
10. public Values Value { get; set; }
12. public string Name
13. {
14. get
15. {
16. //return Value.ToString() + " of " + Suit.ToString(); // The integer values can be converted to their reference names
17. return (Values)Value + " of " + (Suits)Suit; // Here's another way of doing it - Casting to their type, not to string
18. }
19. }
20. }
22. enum Suits
23. {
24. Hearts, // 0 'Hearts' is of type Suits
25. Clubs, // 1
26. Diamonds, // 2
27. Spades // 3
28. }
30. enum Values
31. {
32. Ace=1, // 'Ace' is of type Values
33. Two=2,
34. Three=3,
35. Four=4,
36. Five=5,
37. Six=6,
38. Seven=7,
39. Eight=8,
40. Nine=9,
41. Ten=10,
42. Jack=11,
43. Queen=12,
44. King=13
45. }
Thanks for your interest in the post guys! pack.Length is 52, pack[0].Name="Ace of Hearts" and pack[51].Name="King of Spades" so all is good up to the foreach block.
+1