Input String was not in a correct format.

Peter Dzuya

Hi Everyone.

I wanted to get a value from a Combo and display it on the grid. I am getting this exception "Input string was not in a correct format" . The code is as follows:-

private void CboItemLookUp_EditValueChanged(object sender, EventArgs e) {

try {

currentItem = new StockEO();

currentItem.Load(int.Parse(CboItemLookUp.EditValue.ToString())); // The exception Is thrown here

id = currentItem.ID;

int quan = 1;

if (currentItem.StockAtHand() < quan) {

MessageBox.Show("Insufficient stock amount for item " + currentItem.Name.ToUpper(), "SMIS 2013", MessageBoxButtons.OK, MessageBoxIcon.Warning);

return;

}

Nullable vatAmount = (currentItem.SellPrice * currentItem.Vat) / 100;

Nullable vatableAmount = currentItem.SellPrice + vatAmount;

this.GridPos.Rows.Add(currentItem.ID, currentItem.ItemCode, currentItem.Name, currentItem.SellPrice, quan, currentItem.Vat, vatableAmount, vatAmount, 0, ((currentItem.SellPrice + vatAmount) * quan));

GridPos.CurrentRow.Cells["colQuantity"].Selected = true;

//SendKeys.Send("{ESC}");

GridPos.Focus();

int k = GridPos.Rows.Count;

GridPos.CurrentCell = GridPos.Rows[k - 1].Cells["colQuantity"];

GetTransactionTotals();

} catch (Exception ex) {

MessageBox.Show(ex.GetBaseException().Message, "Error", MessageBoxButtons.OK, MessageBoxIcon.Exclamation);

}

I managed to get the desired Display on the grid. but the exception is thrown before I get the results. Thanks

9 Replies

Know the answer? Post it — somebody with the same question will find it here.

Gowtham Rajamanickam11y ago
public override bool Load(int id) { try { Stock stock = new StockData().Select(id); if (stock != null) { MapEntityToProperties(stock); return true; } else { return false; } } catch { throw; } }
0
Peter Dzuya11y ago
Thank you all for your efforts in assisting me. I have tried each of your suggestion but the exception still exists. I think may be there is something I am not doing right. I attach a class the contains the Load method. public override bool Load(int id) { try { Stock stock = new StockData().Select(id); if (stock != null) { MapEntityToProperties(stock); return true; } else { return false; } } catch { throw; } } Thanks.
0
Peter Dzuya11y ago
Thank you all for your efforts in assisting me. I have tried each of your suggestion but the exception still exists. I think may be there is something I am not doing right. I attach a class the contains the Load method. public override bool Load(int id) { try { Stock stock = new StockData().Select(id); if (stock != null) { MapEntityToProperties(stock); return true; } else { return false; } } catch { throw; } } Thanks.
0
Mukesh Nayak11y ago
Hi Peter

Can you try following and see what the output is

private void CboItemLookUp_EditValueChanged(object sender, EventArgs e)
{
try
{
var parsedOutPut;
var itemLookUpValue = CboItemLookUp.EditValue.ToString();

if (int.TryParse(itemLookUpValue, out parsedOutPut))
{
currentItem = new StockEO();
currentItem.Load(parsedOutPut);
id = currentItem.ID;
int quan = 1;
if (currentItem.StockAtHand() < quan)
{
MessageBox.Show("Insufficient stock amount for item " + currentItem.Name.ToUpper(), "SMIS 2013", MessageBoxButtons.OK, MessageBoxIcon.Warning);
return;
}
Nullable vatAmount = (currentItem.SellPrice * currentItem.Vat) / 100;
Nullable vatableAmount = currentItem.SellPrice + vatAmount;
this.GridPos.Rows.Add(currentItem.ID, currentItem.ItemCode, currentItem.Name, currentItem.SellPrice, quan, currentItem.Vat, vatableAmount, vatAmount, 0, ((currentItem.SellPrice + vatAmount) * quan));
GridPos.CurrentRow.Cells["colQuantity"].Selected = true;
//SendKeys.Send("{ESC}");
GridPos.Focus();
int k = GridPos.Rows.Count;
GridPos.CurrentCell = GridPos.Rows[k - 1].Cells["colQuantity"];
GetTransactionTotals();
}
else
{
MessageBox.Show(itemLookUpValue + " is not in string format");
}

}
catch (Exception ex)
{
MessageBox.Show(ex.GetBaseException().Message, "Error", MessageBoxButtons.OK, MessageBoxIcon.Exclamation);
}
}
0
Tom Mohan11y ago
HI Peter,

In the above code, you are not handling null/empty string properly. use this line of code

currentItem.Load(string.IsNullOrEmpty(CboItemLookUp.EditValue.ToString()) ? 0 : int.Parse(CboItemLookUp.EditValue.ToString()));
0
Peter Dzuya11y ago
Hi @ Akhil Garg.

I added the trim(). Still having the same exception. Thanks
0
Mukesh Nayak11y ago
Hi Peter ,

From the exception it seems the place where you are using int.parse(CboItemLookUp.EditValue.ToString()) the value
CboItemLookUp.EditValue.ToString() is not in an integer format. For example if you try something like

try
{
string objFirst = "abcd";
var value = int.Parse(objFirst);

}
catch (Exception ex)
{
}

You will get the same exception because string "abcd" cannot be converted into integer whereas if you change the var objFirst = "1234" it will work correctly.

I will suggest rather than using int.parse try using int.tryParse .

Hope this will help

0
Akhil Garg11y ago
The value in CboItemLookUp.EditValue.ToString() is not proper either this is null or having some space try this CboItemLookUp.EditValue.ToString().Trim()
0
Rajeesh Menoth11y ago
Put a break point and then check which line you got the error.
0