how to split string dynamically

Venkat S

Hai Friends,

i want to dispaly data in textbox like
id:111
name:venkat
color:green
so befor i display only for data like
111
venkat
green
.................
now i want to display like this

id:111
name:venkat
color:green

here is my code

string str2 = "";
            string[] strListItems;
            int intNumItems = comboBox1.Items.Count;
            strListItems = new string[intNumItems];
            for (int i = 0; i < comboBox1.Items.Count; i++)
            {
                strListItems[i] = ds.Tables[0].Rows[comboBox1.SelectedIndex][i].ToString();
                str2 = str2 + "\r\n " +strListItems[i];
            }
            textBox1.Text = str2;

Please give me any idea.

Thanks
Venkat.S

8 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes15y ago
Accepted answer
If there are 25 rows in ds.Tables[0], then you will get an index out of range exception because strListItems only has 3 elements.

Perhaps what you need is :

for (int i = 0; i < strListItems.Length; i++)
{
str2 += strListItems[i] + ":" + ds.Tables[0].Rows[comboBox1.SelectedIndex][i].ToString() + "\r\n";

}
0
Suthish Nair15y ago
So you need to check the rows count in ds.Tables[0].Rows. Also, which must be equal to comboBox1.Items.Count
0
Venkat S15y ago
i get error below code only

str2 += strListItems[i] + ":" + ds.Tables[0].Rows[comboBox1.SelectedIndex][i].ToString() + "\r\n";

the error is indexoutofrange Exception.

and my full code is
string str2 = "";
            string[] strListItems = { ds.Tables[0].Columns[1].ToString(), ds.Tables[0].Columns[0].ToString(), ds.Tables[0].Columns[2].ToString() };

            for (int i = 0; i < ds.Tables[0].Rows.Count -1; i++)
            {
                str2 += strListItems[i] + ":" + ds.Tables[0].Rows[comboBox1.SelectedIndex][i].ToString() + "\r\n";

            }
            textBox1.Text = str2;

Please resolve my problem.
0
Suthish Nair15y ago
change to int intNumItems = comboBox1.Items.Count - 1; and try
0
Venkat S15y ago
Hi Vulpes
thanks for replay

befor also i have this error.
when i give max 3 records it ll be ok.run succ

when i give 25 records then get error like indexoutofrange.
what is problem, u have any idea .
i read xml file and when i chek records its read xml file.

ya they can be read from the XML file along with the data.

Please share u r ideas to resolve it.

Thanks
VenkatS
0
Vulpes15y ago
If you didn't have any errors before adding those lines, then the only possible reason is that the names array doesn't have enough elements in it.

From what you say, it sounds like it should have 25 elements but I've no idea whether they can be read from the XML file along with the data or whether they have to be added 'manually'.
0
Venkat S15y ago
after added those lines and
now i have some errors

error:indexoutofrange

how to resolve it.my records are in xml file
i have 25 records

0
Vulpes15y ago
Do you mean something like this:

string str2 = "";
string[] strListItems;
int intNumItems = comboBox1.Items.Count;
strListItems = new string[intNumItems];
string[] names = new string[]{"id", "name", "color"}; // needs to be intNumItems in this array

for (int i = 0; i < comboBox1.Items.Count; i++)
{
strListItems[i] = ds.Tables[0].Rows[comboBox1.SelectedIndex][i].ToString();
str2 = str2 + "\r\n" + names[i] + ":" + strListItems[i];
}

textBox1.Text = str2;
0