How to display error message

Ramco Ramco

5y1.5k.NET

I may be repeating this question . I have a Class. I am able to log error in Database but how to return Error message to Controller & display at Client side.

public Add(Location objLoc)
{
try
{
using (SqlConnection con = new SqlConnection(Common.Con))
{
con.Open();
SqlCommand cmd = new SqlCommand("sp_Location", con);
cmd.CommandType = CommandType.StoredProcedure;
cmd.Parameters.AddWithValue("@Id", objLoc.Id);
cmd.Parameters.AddWithValue("@Description", objLoc.Description);

cmd.Parameters.AddWithValue("@IsActive", true);
i = cmd.ExecuteNonQuery();
}
}
catch (Exception ex)
{
ExceptionLogging.SendExcepToDB(ex);
}
}

************* Controller

public ActionResult CreateEdit(Location objLocation , string hfAU , string hfId)
{
if (ModelState.IsValid)
{
dbLocation.Add(objLocation);
TempData["Message"] = "Successfully Saved.";
ModelState.Clear();
}
else
{
var query = from state in ModelState.Values
from error in state.Errors
select error.ErrorMessage;
var errors = query.ToArray();
TempData["Message"] = "Error Encountered.";
}
}

Thanks

12 Replies

Know the answer? Post it — somebody with the same question will find it here.

Sachin Singh5y ago
Accepted answer
yes, obviously one view can do the task, just use one view and one action method for all 3 condition, just the messages will change.
I had given three views thinking that you need 3 different designs for different error types.
protected void Application_Error(object sender, EventArgs e) {
  Exception exception = Server.GetLastError();
  Response.Clear();

  HttpException httpException = exception as HttpException;

  if (httpException != null) {
    string action;

    switch (httpException.GetHttpCode()) {
      case 404:
        // page not found
        action = "myError";
        break;
      case 500:
        // server error
        action = "myError";
        break;
      default:
        action = "myError";
        break;
      }

      // clear error on server
      Server.ClearError();

      Response.Redirect(String.Format("~/Error/{0}/?message={1}", action, exception.Message));
    }
+2
Sachin Singh5y ago
There are no other errors,
Errors are broadly either ModelState errors, Status Codes errors like 404,500, etc, or general code-based errors like divide by zero, StackOverflow, etc.
+2
Ramco Ramco5y ago
Hi Sachin

That's o.k . I deliberately changed it . Will This not cover under this Error Process . How to handle such errors

Thanks
+2
Sachin Singh5y ago
the error is unrelated to the question, your error says that you have no table named Tbl_ExceptionLoggingToDB, which perhaps you are using in your Stored procedure.
ReCheck your SP and ensure that you have a valid table name.
+2
Ramco Ramco5y ago
Hi sachin

Below is my code but it is showing error like this

https://imgur.com/ruti5Ec

View
@ViewBag.ErrorMessage

Controller
public class ErrorController : Controller
{
public ActionResult Index(string message)
{
ViewBag.ErrorMessage = message;
return View();
}
}

Global.asax
protected void Application_Error(object sender, EventArgs e)
{
Exception exception = Server.GetLastError();
Response.Clear();
HttpException httpException = exception as HttpException;
if (httpException != null)
{
string action;
switch (httpException.GetHttpCode())
{
case 404:
// page not found
action = "HttpError404";
break;
case 500:
// server error
action = "HttpError500";
break;
default:
action = "General";
break;
}
// clear error on server
Server.ClearError();
Response.Redirect(String.Format("~/Error/{0}/?message={1}", action, exception.Message));
}
}

Thanks
+2
Ramco Ramco5y ago
Hi Sachin

I have written in Global.asax. 3 views have to be created.
Can 1 view do the task

Thanks
+2
Sachin Singh5y ago
if you are following my code then, your logic will go inside global.asax means place the below code in global.asax
protected void Application_Error(object sender, EventArgs e) {
  Exception exception = Server.GetLastError();
  Response.Clear();

  HttpException httpException = exception as HttpException;

  if (httpException != null) {
    string action;

    switch (httpException.GetHttpCode()) {
      case 404:
        // page not found
        action = "HttpError404";
        break;
      case 500:
        // server error
        action = "HttpError500";
        break;
      default:
        action = "General";
        break;
      }

      // clear error on server
      Server.ClearError();

      Response.Redirect(String.Format("~/Error/{0}/?message={1}", action, exception.Message));
    }
next, you have already created the error controller, so simply create views as
@ViewBag.ErrorMessgae
do styling using bootstrap or css.
+2
Ramco Ramco5y ago
Hi Sachin

I have written below in Error Controller. What is to be written in View

namespace MyApplication.Controllers
{
public class ErrorController : Controller
{
public ActionResult HttpError404(string message)
{
ViewBag.ErrorMessage = message;
return View();
}
public ActionResult HttpError500(string message)
{
ViewBag.ErrorMessage = message;
return View();
}
public ActionResult General(string message)
{
ViewBag.ErrorMessage = message;
return View();
}
}
}

Thanks
+2
Sachin Singh5y ago
First, use the ModelState.IsValid to ensure model validations are Ok and to display the model related errors you already know that you can use @Html.ValidationMessageFor() or @Html.ValidationSummary();

To Explicitely add specific Model Errors use ModelState.AddModelError("Key",Value); and Display the Error using Html.ValidationMessageFor(x=>x.Key);

Use Catch block to just catch the internal server error or the logical errors related to code and not related to models, to display the errors of the catch block , write your own logic as shown below
protected void Application_Error(object sender, EventArgs e) {
  Exception exception = Server.GetLastError();
  Response.Clear();

  HttpException httpException = exception as HttpException;

  if (httpException != null) {
    string action;

    switch (httpException.GetHttpCode()) {
      case 404:
        // page not found
        action = "HttpError404";
        break;
      case 500:
        // server error
        action = "HttpError500";
        break;
      default:
        action = "General";
        break;
      }

      // clear error on server
      Server.ClearError();

      Response.Redirect(String.Format("~/Error/{0}/?message={1}", action, exception.Message));
    }
now create an Error Controller and inside that three Action Method as
public ActionResult HttpError404(string message)
{

ViewBag.ErrorMessage=message;

return View();
}
public ActionResult HttpError500(string message)
{

ViewBag.ErrorMessage=message;

return View();
}
public ActionResult General(string message)
{

ViewBag.ErrorMessage=message;

return View();
}
//view for all 3
@ViewBag.ErrorMessage
+2
Arnab Mukherjee5y ago
Please try the below one,
public class CustomeObject
{
public string message {get;set;}
public List lst {get;set;}
}

public class LocationDb
{
int i;
public CustomeObject GetAllLocation()
{
CustomeObject obj=new CustomeObject();
List objLocation = new List();
try
{
using (SqlConnection con = new SqlConnection(Common.Con))
{
con.Open();
SqlCommand cmd = new SqlCommand("sp_Location", con);
cmd.CommandType = CommandType.StoredProcedure;
cmd.Parameters.AddWithValue("@Action", "R");
SqlDataReader rdr = cmd.ExecuteReader();
while (rdr.Read())
{
objLocation.Add(new Location
{
Id = rdr["Id"].ToString(),
Description = rdr["Description"].ToString(),
});
}
}
}
catch (Exception ex)
{
ExceptionLogging.SendExcepToDB(ex);
obj.message = ex.Message;
}
obj.lst=objLocation;
return obj;
}
+2
Ramco Ramco5y ago
Hi Arnab

How i write in the below code

public class LocationDb
{
int i;
string output = string.Empty;
public List GetAllLocation()
{
List objLocation = new List();
try
{
using (SqlConnection con = new SqlConnection(Common.Con))
{
con.Open();
SqlCommand cmd = new SqlCommand("sp_Location", con);
cmd.CommandType = CommandType.StoredProcedure;
cmd.Parameters.AddWithValue("@Action", "R");
SqlDataReader rdr = cmd.ExecuteReader();
while (rdr.Read())
{
objLocation.Add(new Location
{
Id = rdr["Id"].ToString(),
Description = rdr["Description"].ToString(),
});
}
}
}
catch (Exception ex)
{
ExceptionLogging.SendExcepToDB(ex);
output = ex.Message;
}
return objLocation;
}

Thanks
+2
Arnab Mukherjee5y ago
Please modify your Add method to return a string like below.
public string Add(Location objLoc)
{
       string output=string.Empty;
            try
            {
                using (SqlConnection con = new SqlConnection(Common.Con))
                {
                    con.Open();
                    SqlCommand cmd = new SqlCommand("sp_Location", con);
                    cmd.CommandType = CommandType.StoredProcedure;
                    cmd.Parameters.AddWithValue("@Id", objLoc.Id);
                    cmd.Parameters.AddWithValue("@Description", objLoc.Description);

                    cmd.Parameters.AddWithValue("@IsActive", true);
                    i = cmd.ExecuteNonQuery();
            output="Success";
                }
            }
            catch (Exception ex)
            {
                ExceptionLogging.SendExcepToDB(ex);
        output=ex.Message;
            }
        return output;
        }
Now modify your CreateEdit Controller like below.
public ActionResult CreateEdit(Location objLocation , string hfAU , string hfId)

        string result=string.Empty;
               if (ModelState.IsValid)
               {
                    result =   dbLocation.Add(objLocation);
                    ModelState.Clear();
              return Json(new { success = true, responseText = result }, JsonRequestBehavior.AllowGet);
               }
               else
               {
                   var query = from state in ModelState.Values
                               from error in state.Errors
                               select error.ErrorMessage;
                   var errors = query.ToArray();
                return Json(new { success = false, responseText = "Your error message goas here" }, JsonRequestBehavior.AllowGet);

               }
Now try to call this controller from client side.
+3