How to call one controller from another controller in asp.net core api

Sujeet Raman

5y33.8k.NET

Hi, this description may weired! but as a POC I want to do something like ..

I have an Employee controller .this controller is concidered as main controller and having a methode which fetch all the employee details based on their grade.Now i have to create 2 microservices for my project.Age and Gender is the 2 seperate MS.I want to know the correct way of creating/implimenting these microservices.

In Employee controller

[HttpPost("api/Employee/GetallEmployee")]
public async Task GetallEmployee(input)
{
//i have to get merged json result here from below controllers(2 microservices having seperate db and seperate controller) and this url will connect with API gateway
// I should merge these 2 result( using newtonsoft i can do it)
//the merged json responce will concidered as main api
//is this the correct way to create microservices?
mergedresult= result1+result2
}

But in this i have some microservices like Age and Gender means for creating microservices in to my solution i have created seperate 2 controller like AgeController and GenderController

But the challenge i am facing is i have to call the main api only api/Employee/GetallEmployee

by using this i have to call both below controller and in main methode i shud combain the 2 joson results.Anyone please help me

AgeController

[HttpPost("api/Age/Ageofall")]
public async Task Ageofall(input)
{
var result1 = await _getemployee.getalldetails(input);
return new JsonResult(result1);
}
GenderController
[HttpPost("api/Gender/Genderofall")]
public async Task Genderofall(input)
{
var result2 = await _getemployee.getalldetails(input);
return new JsonResult(result2);
}

Please suggest the best practice to create microservices if i am doing wrong here..Thanks

2 Replies

Know the answer? Post it — somebody with the same question will find it here.

Asma Khalid5y ago
In MVC design pattern controller can not directly call another controller. As already mention by Sachin, separate your business logic then call that instead, but, if separating your business logic is a cumbersome task then call these controller as a normal Web APIs using HTTPClient class inside your target controller. Look into this for calling Web APIs usin HTTPClient i.e. https://bit.ly/314PBZ2

Mark answer as accpted if helpful

Thanks & Regards,
Asma Khalid

For More Visit: www.asmak9.com or www.bytezaar.com

0
Sachin Singh5y ago
No this is obviously not the right way to go, better is to seperate the logic from controller completely , make a separate Business layer and different classes for example
public class EmployeeBL
{
public List GetGender()
{
var res= (from emp in _getEmployee.getalldetails
          select new {
   Name=emp.Name,
   Gender=emp.Gender
}).ToList()
return res;
}
public List GetAge()
{
var res= (from emp in
_getEmployee.getalldetails
select new
{
Name=emp.Name,
Age=emp.Age,

}).ToList();
return res;
}
and reuse this logic anywhere in any controller
[HttpPost("api/Employee/GetallEmployee")]

public async Task GetallEmployee(input)

{
EmployeeBL  obj=new
EmployeeBL  ()
var res1=obj.GetGender('Male');
var res2=obj.GetAge

mergedresult= res1+ res2;


}
0