how can i remove multiple if statement.?

C# Corner

Naveen Bisht

9y10.8kLearn iOS Programming

how can i remove multiple if statement.?

eg. if (a=="something")

{

}else if(b==" something"

{

}

...

.....

like this if multiple of if condtion in program how can i remove it shortes one.

11 Replies

Know the answer? Post it — somebody with the same question will find it here.

Jamil Moughal9y ago
You can avoid multiple if statements by using Switch statement or ternary operators
0
Sivasankar Gorantla9y ago
Hi,

- If you have two conditions then go for "Ternary" operator.

- If you have multiple if statements in your code then it is better to convert them into switch statements. switch statement is faster than if statement in many cases. Because it internally implements hashtable for lookups.

Thanks,
Siva
0
Satyaprakash Samantaray9y ago
Use switch case
0
Vishal Verma9y ago
Simple way -Use switch case.
Advanced with few lines of code -Use any pattern suitable to your case .e.g -Strategy pattern
0
Anil Jha9y ago
1. class DiscountCalculator
2. {
3. public int CustomerType { get; set; }
5. public double CalculateDiscount(double totalSales)
6. {
7. double discount = 0;
8. if (CustomerType == 1)
9. {
10. discount = totalSales * 0.15;
11. }
12. else if (CustomerType == 2)
13. {
14. discount = totalSales * 0.10;
15. }
16. else if (CustomerType == 3)
17. {
18. discount = totalSales * 0.05;
19. }
21. return discount;
22. }
23. }
I think above is your code and you want to improve this if-else statement. So you can improve it by using below code.
interface IDiscount
    {
        double GetDiscount(double totalSales);
    }

class SilverCustomer: IDiscount
    {
        public double GetDiscount(double totalSales)
        {
            // 10% discount for silver customer
            return totalSales * 0.10;
        }
    }

class GoldCustomer: IDiscount
    {
        public double GetDiscount(double totalSales)
        {
            // 15% discount for gold customer
            return totalSales * 0.15;
        }
    }

class NormalCustomer: IDiscount
    {
        public double GetDiscount(double totalSales)
        {
            // 5% discount for silver customer
            return totalSales * 0.05;
        }
    }

class DiscountCalculator
    {
        IDiscount _iDiscount;
        public DiscountCalculator(IDiscount customerType)
        {
            this._iDiscount = customerType;
        }

        public double CalculateDiscount(double totalSales)
        {
            return _iDiscount.GetDiscount(totalSales);
        }
    }
class Program
   {
       static void Main(string[] args)
       {
           DiscountCalculator discountGoldCustomer = new DiscountCalculator(new GoldCustomer());
           double discountForGoldCustomer = discountGoldCustomer.CalculateDiscount(1000);
           Console.WriteLine("Discount for gold customer: " + discountForGoldCustomer);

           DiscountCalculator discountNormalCustomer = new DiscountCalculator(new NormalCustomer());
           double discountForNormalCustomer = discountNormalCustomer.CalculateDiscount(1000);
           Console.WriteLine("Discount for normal customer: " + discountForNormalCustomer);

           Console.ReadKey();
       }
   }

In new DiscountCalculator class, if you want to calculate discount for whatever customer you don't need alter DiscountCalculator class rather you will create new customer class. For example if you want to calculate discount for Platinum customer then you don't need to alter DiscountCalculator class, just create PlatinumCustomer class.
class PlatinumCustomer:IDiscount
    {
        public double GetDiscount(double totalSales)
        {
            // 20% discount for platinujm customer
            return totalSales * 0.20;
        }
    }

class Program
    {
        static void Main(string[] args)
        {
            DiscountCalculator discountGoldCustomer = new DiscountCalculator(new GoldCustomer());
            double discountForGoldCustomer = discountGoldCustomer.CalculateDiscount(1000);
            Console.WriteLine("Discount for gold customer: " + discountForGoldCustomer);

            DiscountCalculator discountNormalCustomer = new DiscountCalculator(new NormalCustomer());
            double discountForNormalCustomer = discountNormalCustomer.CalculateDiscount(1000);
            Console.WriteLine("Discount for normal customer: " + discountForNormalCustomer);

            DiscountCalculator discountPlatinumCustomer = new DiscountCalculator(new PlatinumCustomer());
            double discountForPlatinumCustomer = discountPlatinumCustomer.CalculateDiscount(1000);
            Console.WriteLine("Discount for platinum customer: " + discountForPlatinumCustomer);

            Console.ReadKey();
        }
    }
In this way we have removed if-else statement.
+3

Naveen Bisht9y ago

if I will use switch instead of if the thing is same except performance only I want to remove line of if -else and write a generic code for same

Ibrahim Siddique9y ago

you can use two option one is ternary operator and the second one is Switch case

1. Example :

int result = Check() ? 1 : 0;

2. Example :

switch (grade)

 { case 'A': Console.WriteLine("Excellent!"); break;

case 'B': Console.WriteLine("Good Job!"); break;

 case 'C': Console.WriteLine("Well done"); break;

 case 'D': Console.WriteLine("You passed"); break;

 case 'F': Console.WriteLine("Better try again"); break;

default: Console.WriteLine("Invalid grade"); break; }

Anil Jha9y ago

To remove if-else statement in C#, you can use ternary operator or switch - case statement.

I would suggest you to achieve it using decoulpled architure using Dependency injection.

Nimish Saxena9y ago

You can use ternary operator.

for eg:- var res=a == "something"?"something1":"something2" ;

this produce same result as if else.

Abhilash J A9y ago

Okay, Let's say...

public string GetAdvertisementType(string type)
{
switch (type)
{
case "PS":
return "Product search";
break;
case "SS":
return "Services search";
break;
case "ST":
return "Scrollable text";
break;
default:
return "";
break;
}
}

Cheers !!!

Ramesh Barik9y ago

You can use switch-statement instade of if. switch is more perfermance tuned.

Check this link to know more.

https://stackoverflow.com/questions/2158759/case-vs-if-else-if-which-is-more-efficient