Form not closing in Form.Close() function

Bineesh Viswanath

Dear All,

I need your help to solve below issue:-

I have an issue when I am trying to close a windows form by calling form.close() function.

The scenario is mentioned below:-

I am using a mdi form. From menu I opened a child form. Then from child form(child), I opened another form(non -child)outside the container. in non child form I am using a database insert function. After insert, I am closing the non child form and I need to re open the child form in order to reflect the data saved from non child form.

in non child form , I wrote like this:-

frmMain mainObj = new frmMain();

Close();

mainObj.OpenAssetViewForm();

And in Main form , i wrote like this to open child form within container.

public void OpenAssetViewForm()
{
try
{
foreach (Form frmObj in Application.OpenForms)
{
if (frmObj.Name == "frmAssetRegView")
{
frmObj.Close();
if (frmObj == null)// is not changing into null
{
frmObj.Show();
}
break;
}
}
}
catch (Exception ex)
{
}
}

8 Replies

Know the answer? Post it — somebody with the same question will find it here.

Bineesh Viswanath7y ago
Dear All,

I have solved this issue in a simple manner..,

internal FrmAssetRegView FrmRegView { get; set; }// form declared in non child form

FrmAssetReg frmReg = new FrmAssetReg();
frmReg.AssetId = CommonCls.objAstReg.assetID;
frmReg.FrmRegView = this;
frmReg.Show();
And the Form_load event modifier changed to public:-

public void frmAssetRegView_Load(object sender, EventArgs e)
{
try
{
LoadGridData();
}
catch (Exception ex)
{
MessageBox.Show(ex.Message);
}
}

And called the event from non child form button click event.

FrmRegView.frmAssetRegView_Load(sender, e);
0
Bineesh Viswanath7y ago
Dear Rajanikant,

The latest code also not working for me.

I did few changes in the code and Its working for me.

When I open non child form, the passed the child form variable into the non child form.

then, while closing the non child form, the called the same form obj ( frmRegView.) and wrote a public function (ReloadForm)in child form.

frmRegView.Controls.Clear();
frmRegView.ReloadForm();// Function calling

The above called function definition:-

public void ReloadForm()
{
InitializeComponent();
LoadGridData();

}
+1
Rajanikant Hawaldar7y ago
Hi Bineesh i created sample application working fine, wrong with your code is foreach dont allow to set any value to its item because its read only. Let me know issue is resolved or not.
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;

namespace WindowsFormsApplication1
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }
        Form two = new Form();
        Form three = new Form();
        private void btnform2_Click(object sender, EventArgs e)
        {
            two.Show();
        }
        private void btnform3_Click(object sender, EventArgs e)
        {
            three.Text = "FormThree";
            three.Show();
        }
        private void btnDispose_Click(object sender, EventArgs e)
        {
            Form f;//form obj
            for (int i = 0; i < Application.OpenForms.Count; i++)
            {
                if (Application.OpenForms[i].Text== "FormThree")
                {
                    f = Application.OpenForms[i];
                    f.Close();
                    f = null;
                    if (f==null)
                    {
                        //f is null
                    }
                }
            }
        }
    }
}
0
Bineesh Viswanath7y ago
Hello priyanka,

The code you provided also not working for me. The form obj not coming to null after called Dispose() and Close().
0
Priyanka Jain7y ago
Try using below code,
frmObj.Dispose();
frmObj.Close();
It first delete objects from memory than closes the form
0
Rajanikant Hawaldar7y ago
After call dispose() set frmObj = null;
0
Bineesh Viswanath7y ago
Dear Rajanikanth,

I have called dispose method after frmObj.Close().

Still that form obj not becoming to null.
0
Rajanikant Hawaldar7y ago
Once you call insert function in non child form you can also pass this data to child form to reflect changes using delegate event so when you close non child form don't close child form. Calling Close function with form object frmObj.Close() frmObj will not become null you have to call dispose() set as null.
0