Convert file to byte from text

mike Delvotti

Guys i'm a little stuck on the below, it works fine for uploading text files, but really i need it to upload jpg/jpeg/png is there a simple way to adapt somewhere below to upload images?

At the moment it places a jpg in the destination folder, but the file is not viewable or contains no information?

// Get the object used to communicate with the server.
                FtpWebRequest request = (FtpWebRequest)WebRequest.Create("ftpserver" + "/" + label1.Text + "" + "Winter.jpg");
                request.Method = WebRequestMethods.Ftp.UploadFile;
                //Path.GetFileName(filePath));
                // This example assumes the FTP site uses anonymous logon.
                request.Credentials = new NetworkCredential("username", "password");

// Copy the contents of the file to the request stream.
StreamReader sourceStream = new StreamReader(@"C:\\Winter.jpg");

                I feel my problem is here somewhere?
                byte[] fileContents = Encoding.UTF8.GetBytes(sourceStream.ReadToEnd());
                sourceStream.Close();
                request.ContentLength = fileContents.Length;

                Stream requestStream = request.GetRequestStream();
                requestStream.Write(fileContents, 0, fileContents.Length);
                requestStream.Close();

FtpWebResponse response = (FtpWebResponse)request.GetResponse();

Console.WriteLine("Upload File Complete, status {0}", response.StatusDescription);

response.Close();

7 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes14y ago
Accepted answer
Try this:

FtpWebRequest request = (FtpWebRequest)WebRequest.Create("ftpserver" + "/" + label1.Text + "" + "Winter.jpg");
request.Method = WebRequestMethods.Ftp.UploadFile;
request.Credentials = new NetworkCredential("username", "password");

Image img = Image.FromFile(@"C:\Winter.jpg"); // notice single back-slash
MemoryStream ms = new MemoryStream();
img.Save(ms, System.Drawing.Imaging.ImageFormat.Jpeg);
byte[] fileContents = ms.ToArray();
request.ContentLength = fileContents.Length;

Stream requestStream = request.GetRequestStream();
requestStream.Write(fileContents, 0, fileContents.Length);
requestStream.Close();

FtpWebResponse response = (FtpWebResponse)request.GetResponse();

Console.WriteLine("Upload File Complete, status {0}", response.StatusDescription);

response.Close();
0
mike Delvotti14y ago
Of course, now you've pointed that out I have no idea why i thought of placing the picturebox source in the streamreader, when the image source sits within this line: img = Image.FromFile(@"C:\Winter.jpg"); doh.

Thanks once again :)
0
Prime b14y ago
oh ok
0
Vulpes14y ago
Because it's designed to read text in a particular encoding, not binary data.
0
Prime b14y ago
Why wouldn't you use StreamReader?
0
Vulpes14y ago
I wouldn't use StreamReader for image files, Mike. Instead I'd replace this line:

Image img = Image.FromFile(@"C:\Winter.jpg");

with this:

Image img = pictureBox1.Image;

and leave the rest of the code as it is.
0
mike Delvotti14y ago
Wondeful, that works a treat, thank you Vulpes.

Could i be a bit cheeky and ask another quick question? at the moment i pull the image from: (@"C:\\Winter.jpg"); but lets say the image was already in pictureBox1 could i send that direct to ftp with something like:

StreamReader sourceStream = new StreamReader(Picturebox1.image);

or is that way off the mark?
0