C# program answer needed immediately pls help

Azm Amn

Question

1. Write a program that randomly fills a 3 by 4 by 6 array, then prints the largest and smallest values in the array.

I have my code below please help me solve. The problem is when i run it shows me the 2nd smallest number. There is a bug in it. please help me solve it.

namespace _3_dimensional_array

{

class Program

{

static void Main(string[] args)

{

int[, ,] x = new int[3, 4, 6]; // declaration of multi-dimensional array

int i, c, b;

int k = 0, l = 0, m = 0, n = 0, o = 0, s = 0; // to use in input for loop

int t, y, u; // to find a maximum loop

Console.WriteLine("Enter 3 values :");

for (i = 0; i < 3; i++)

{

x[i, k, l] = Convert.ToInt32(Console.ReadLine());

}

Console.WriteLine("Enter 4 values :");

for (c = 0; c < 4; c++)

{

x[m, c, n] = Convert.ToInt32(Console.ReadLine());

}

Console.WriteLine("Enter 6 values :");

for (b = 0; b < 6; b++)

{

x[s, o, b] = Convert.ToInt32(Console.ReadLine());

}

// loops for input

t = x[0, k, l];

y = x[m, 0, n];

u = x[s, o, 0];

for (int q = 1; q < 3; q++)

{

if (t < x[q, k, l])

{

t = x[q, k, l];

}

for (int p = 1; p < 4; p++)

{

if (y < x[m, p, n])

{

y = x[m, p, n];

}

for (int h = 1; h < 6; h++)

{

if (u < x[s, o, h])

{

u = x[s, o, h];

}

// loops for maximum value

int yu; // to assing maximum value

if ((t > y) && (t > u))

{

yu = t;

}

else if ((y > t) && (y > u))

{

yu = y;

}

else

{

yu = u;

}

// to find maximum value

Console.WriteLine("The maximum value is {0}.", yu);

int sd, af, qw; // use to find minimum value

sd = x[0, k, l];

af = x[m, 0, n];

qw = x[s, o, 0];

for (int a = 0; a < 3; a++)

{

if (sd > x[a, k, l])

{

sd = x[a, k, l];

}

for (int f = 0; f < 4; f++)

{

if (af > x[m, f, n])

{

af = x[m, f, n];

}

for (int j = 0; j < 6; j++)

{

if (qw > x[s, o, j])

{

qw = x[s, o, j];

}

// for loop for minimum value

int mu; // it is assigned to minimum value

if ((sd

{

mu = sd;

}

else if (sd > af && qw > af)

{

mu = af;

}

else

{

mu = qw;

}

// used to find minimum value

Console.WriteLine("The minimum value {0}.", mu);

// holding output screen

Console.ReadLine();

}

14 Replies

Know the answer? Post it — somebody with the same question will find it here.

Azm Amn12y ago
A million thanks vulpes you have helped me very much in my work.
0
Vulpes12y ago
Well, one way to do that would be to change the size of the array to 3 x 5 x 7. You'd then need to change the upper bounds of the loops to match.

However, a slightly easier way which doesn't involve as much disruption to the program would be to cache the first two values of x[0, 0, 0] to individual variables (v and w say) before they're overwritten.

At the end of the program, you can then check whether these cached values are smaller or larger than the other values and, if they are, adjust the output accordingly. Here's the code to do that:

using System;

namespace _3_dimensional_array
{
class Program
{
static void Main(string[] args)
{
int[, ,] x = new int[3, 4, 6]; // declaration of multi-dimensional array
int i, c, b;
int k = 0, l = 0, m = 0, n = 0, o = 0, s = 0; // to use in input for loop
int t, y, u; // to find a maximum loop
int v, w; // to cache the overwritten values of x[0, 0, 0]
Console.WriteLine("Enter 3 values :");
for (i = 0; i < 3; i++)
{
x[i, k, l] = Convert.ToInt32(Console.ReadLine());
}
v = x[0, 0, 0];
Console.WriteLine("Enter 4 values :");
for (c = 0; c < 4; c++)
{
x[m, c, n] = Convert.ToInt32(Console.ReadLine());
}
w = x[0, 0, 0];
Console.WriteLine("Enter 6 values :");
for (b = 0; b < 6; b++)
{
x[s, o, b] = Convert.ToInt32(Console.ReadLine());
}
// loops for input
t = x[0, k, l];
y = x[m, 0, n];
u = x[s, o, 0];
for (int q = 1; q < 3; q++)
{
if (t < x[q, k, l])
{
t = x[q, k, l];
}
}
for (int p = 1; p < 4; p++)
{
if (y < x[m, p, n])
{
y = x[m, p, n];
}
}
for (int h = 1; h < 6; h++)
{
if (u < x[s, o, h])
{
u = x[s, o, h];
}
}
// loops for maximum value
int yu; // to assing maximum value
if ((t > y) && (t > u))
{
yu = t;
}
else if ((y > t) && (y > u))
{
yu = y;
}
else
{
yu = u;
}
// to find maximum value
if (yu < v) yu = v;
if (yu < w) yu = w;
Console.WriteLine("The maximum value is {0}.", yu);
int sd, af, qw; // use to find minimum value
sd = x[0, k, l];
af = x[m, 0, n];
qw = x[s, o, 0];
for (int a = 0; a < 3; a++)
{
if (sd > x[a, k, l])
{
sd = x[a, k, l];
}
}
for (int f = 0; f < 4; f++)
{
if (af > x[m, f, n])
{
af = x[m, f, n];
}
}

for (int j = 0; j < 6; j++)
{
if (qw > x[s, o, j])
{
qw = x[s, o, j];
}
}
// for loop for minimum value
int mu; // it is assigned to minimum value
if ((sd
{
mu = sd;
}
else if (sd > af && qw > af)
{
mu = af;
}
else
{
mu = qw;
}
// used to find minimum value
if (mu > v) mu = v;
if (mu > w) mu = w;
Console.WriteLine("The minimum value {0}.", mu);
// holding output screen
Console.ReadLine();
}
}
}

0
Azm Amn12y ago
IS there a way you can find the solution without changing the values to be entered. i.e keeping the elements input same without changing. E.g. following the first program order 3,4,and 6 elements
0
Azm Amn12y ago
thank you a lot
0
Vulpes12y ago
I thought you said before that your lecturer just wanted you to find the bug and not worry about the solution?

Anyway, as I said in my previous post, the bug is that x[0, 0, 0] is being set three times and therefore has the final value it's set to. The other two values are just overwritten and so don't figure in the minimum and maximum calculations.

To fix it, you need to avoid the overwriting which means that 'c' and 'b' both need to start iterating from 1, not 0. This also means that you'll need to ask the user for 3, 3 and 5 numbers rather than 3, 4 and 6.

I've made the highlighted changes to the program which now seems to be running OK:

using System;

namespace _3_dimensional_array
{
class Program
{
static void Main(string[] args)
{
int[, ,] x = new int[3, 4, 6]; // declaration of multi-dimensional array
int i, c, b;
int k = 0, l = 0, m = 0, n = 0, o = 0, s = 0; // to use in input for loop
int t, y, u; // to find a maximum loop
Console.WriteLine("Enter 3 values :");
for (i = 0; i < 3; i++)
{
x[i, k, l] = Convert.ToInt32(Console.ReadLine());
}
Console.WriteLine("Enter 3 values :"); //** changed 4 to 3
for (c = 1; c < 4; c++) //** changed 0 to 1
{
x[m, c, n] = Convert.ToInt32(Console.ReadLine());
}
Console.WriteLine("Enter 5 values :"); //** changed 6 to 5
for (b = 1; b < 6; b++) //** changed 0 to 1
{
x[s, o, b] = Convert.ToInt32(Console.ReadLine());
}
// loops for input
t = x[0, k, l];
y = x[m, 0, n];
u = x[s, o, 0];
for (int q = 1; q < 3; q++)
{
if (t < x[q, k, l])
{
t = x[q, k, l];
}
}
for (int p = 1; p < 4; p++)
{
if (y < x[m, p, n])
{
y = x[m, p, n];
}
}
for (int h = 1; h < 6; h++)
{
if (u < x[s, o, h])
{
u = x[s, o, h];
}
}
// loops for maximum value
int yu; // to assing maximum value
if ((t > y) && (t > u))
{
yu = t;
}
else if ((y > t) && (y > u))
{
yu = y;
}
else
{
yu = u;
}
// to find maximum value
Console.WriteLine("The maximum value is {0}.", yu);
int sd, af, qw; // use to find minimum value
sd = x[0, k, l];
af = x[m, 0, n];
qw = x[s, o, 0];
for (int a = 0; a < 3; a++)
{
if (sd > x[a, k, l])
{
sd = x[a, k, l];
}
}
for (int f = 0; f < 4; f++)
{
if (af > x[m, f, n])
{
af = x[m, f, n];
}
}

for (int j = 0; j < 6; j++)
{
if (qw > x[s, o, j])
{
qw = x[s, o, j];
}
}
// for loop for minimum value
int mu; // it is assigned to minimum value
if ((sd
{
mu = sd;
}
else if (sd > af && qw > af)
{
mu = af;
}
else
{
mu = qw;
}
// used to find minimum value
Console.WriteLine("The minimum value {0}.", mu);
// holding output screen
Console.ReadLine();
}
}
}

0
Azm Amn12y ago
whaterver minimum value i enter in i and c loop it always shows me the second lowest rather than the 1st lowest. But on b loop it shows the smallest value if i enter data inside the b loop.
0
Azm Amn12y ago
But my lecturer told me that he had found the solution and it works. SO i think there should be an option.
0
Vulpes12y ago
Well, one problem (there may be others) is that the first values entered in the 'i' loop and the 'c' loop are always overwritten by the first value entered in the 'b' loop and consequently these values never figure in the calculation of the minimum and maximum values at all!
0
Azm Amn12y ago
sorry I accidently typed largest it is smallest/lowest number
0
Azm Amn12y ago
Thank you.

Actually the program which i put is what my lecturer gave me.

namespace _3_dimensional_array
{
class Program
{
static void Main(string[] args)
{
int[, ,] x = new int[3, 4, 6]; // declaration of multi-dimensional array
int i, c, b;
int k = 0, l = 0, m = 0, n = 0, o = 0, s = 0; // to use in input for loop
int t, y, u; // to find a maximum loop
Console.WriteLine("Enter 3 values :");
for (i = 0; i < 3; i++)
{
x[i, k, l] = Convert.ToInt32(Console.ReadLine());
}
Console.WriteLine("Enter 4 values :");
for (c = 0; c < 4; c++)
{
x[m, c, n] = Convert.ToInt32(Console.ReadLine());
}
Console.WriteLine("Enter 6 values :");
for (b = 0; b < 6; b++)
{
x[s, o, b] = Convert.ToInt32(Console.ReadLine());
}
// loops for input
t = x[0, k, l];
y = x[m, 0, n];
u = x[s, o, 0];
for (int q = 1; q < 3; q++)
{
if (t < x[q, k, l])
{
t = x[q, k, l];
}
}
for (int p = 1; p < 4; p++)
{
if (y < x[m, p, n])
{
y = x[m, p, n];
}
}
for (int h = 1; h < 6; h++)
{
if (u < x[s, o, h])
{
u = x[s, o, h];
}
}
// loops for maximum value
int yu; // to assing maximum value
if ((t > y) && (t > u))
{
yu = t;
}
else if ((y > t) && (y > u))
{
yu = y;
}
else
{
yu = u;
}
// to find maximum value
Console.WriteLine("The maximum value is {0}.", yu);
int sd, af, qw; // use to find minimum value
sd = x[0, k, l];
af = x[m, 0, n];
qw = x[s, o, 0];
for (int a = 0; a < 3; a++)
{
if (sd > x[a, k, l])
{
sd = x[a, k, l];
}
}
for (int f = 0; f < 4; f++)
{
if (af > x[m, f, n])
{
af = x[m, f, n];
}
}
for (int j = 0; j < 6; j++)
{
if (qw > x[s, o, j])
{
qw = x[s, o, j];
}
}
// for loop for minimum value
int mu; // it is assigned to minimum value
if ((sd
{
mu = sd;
}
else if (sd > af && qw > af)
{
mu = af;
}
else
{
mu = qw;
}
// used to find minimum value
Console.WriteLine("The minimum value {0}.", mu);
// holding output screen
Console.ReadLine();
}
}
}

what he needs is that he wants me to find the error regardless of the question. He is saying to find the bug in the program and not to worry about the solution. When you run the program it would give second lowest number. It gives the second largest number when you enter the lowest value after it says enter 3 values and enter 4 values. But if you enter lowest number inside the enter 6 values it shows the correct answer. When i asked my lecturer he told there is a problem with the logical operators in the last part. Please help me
0
Vulpes12y ago
In that case, you'll need to change the program to the following:

namespace _3_dimensional_array
{
class Program
{
static void Main(string[] args)
{
int[, ,] x = new int[3, 4, 6]; // declaration of multi-dimensional array

// ask user for 72 integers
int min = int.MaxValue;
int max = int.MinValue;

Console.WriteLine("Enter elements for a 3 x 4 x 6 integer array\n");

for(int i = 0; i < 3; i++)
{
for(int j = 0; j < 4; j++)
{
for(int k = 0; k < 6; k++)
{
Console.Write(" Element({0}, {1}, {2}) : ", i, j, k);
// note x[i,j,k] will be zero if input non-integral
int.TryParse(Console.ReadLine(), out x[i, j, k]);
if(max < x[i, j, k]) max = x[i, j, k];
if(min > x[i, j, k]) min = x[i, j, k];
}
}
}

Console.WriteLine("\n\nThe largest number is {0}", max);
Console.WriteLine("The smallest number is {0}", min);
Console.ReadKey();
}
}
}
0
Azm Amn12y ago
what if i want to get input from the user and display largest and smallest please reply htnak you
0
Azm Amn12y ago
Thank you very much
0
Vulpes12y ago
I think that you may have misunderstood the question.

A 3 by 4 by 6 array contains 72 elements whereas you're asking the user to input 13.

Also the question asks you to randomly fill the array rather than ask the user to input them which wouldn't be very practical for an array of this size.

So I'd generate 72 random numbers between 0 and 99 (say), print them out and then print the largest and smallest ones. The code to do this is quite compact:

using System;

namespace _3_dimensional_array
{
class Program
{
static void Main(string[] args)
{
int[, ,] x = new int[3, 4, 6]; // declaration of multi-dimensional array
Random r = new Random(); // declaration of random object

// generate 72 numbers between 0 and 99
int min = 100; // impossible value
int max = -1; // ditto

Console.WriteLine("The random numbers are\n");

for(int i = 0; i < 3; i++)
{
for(int j = 0; j < 4; j++)
{
for(int k = 0; k < 6; k++)
{
x[i, j, k] = r.Next(100); // excludes end point
Console.Write("{0, 2} ", x[i, j, k]);
if(max < x[i, j, k]) max = x[i, j, k];
if(min > x[i, j, k]) min = x[i, j, k];
}
}
}

Console.WriteLine("\n\nThe largest number is {0}", max);
Console.WriteLine("The smallest number is {0}", min);
Console.ReadKey();
}
}
}
0