C# home controller image upload query isn't working

Emmmanuel FIADUFE

public ActionResult FileUpload()
{
    string relativePath = string.Empty;
    if (file != null)
    {
        // string ImageUniqueName = Guid.NewGuid().ToString();
        //string ActualImageName = ImageUniqueName + Path.GetFileName(file.FileName);
        string pic = System.IO.Path.GetFileName(file.FileName);
        path = System.IO.Path.Combine(Server.MapPath("/images/profile"), pic);
        // file is uploaded
        file.SaveAs(path);
        relativePath = Path.Combine("/images/profile", ActualImageName);
    }
    return Json(relativePath, JsonRequestBehavior.AllowGet);
}

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vishal Joshi2y ago
Accepted answer
Hello, Emmanuel ,

Please check you ajax call for request for the API.

Remove Type as json.

Also In parameter it requires file parameter of type HttpPostedFileBase

so it should be like below

public ActionResult FileUpload(HttpPostedFileBase file){}

Thanks

Vishal Joshi
+1
Emmmanuel FIADUFE2y ago
Thank you team for your support
+1
Emmmanuel FIADUFE2y ago
Thank you Naimish, please I will check and revert
+3
Naimish Makwana2y ago
There are a few issues with your code. Here’s a corrected version:
```
public ActionResult FileUpload(HttpPostedFileBase file)
{
    string relativePath = string.Empty;

    if (file != null && file.ContentLength > 0)
    {
        var fileName = Path.GetFileName(file.FileName);
        var path = Path.Combine(Server.MapPath("~/uploads/"), fileName);
        file.SaveAs(path);
        relativePath = Url.Content("~/uploads/" + fileName);
    }

    return Json(new { path = relativePath }, JsonRequestBehavior.AllowGet);
}
```
In this corrected version:
- The parameter file is of type HttpPostedFileBase which represents an uploaded file.
- We check if the file is not null and if it has content.
- We get the file name and combine it with the path where we want to save the file. In this case, it’s the “uploads” folder at the root of the server.
- We save the file using file.SaveAs(path).
- We create the relative path for the uploaded file.
- Finally, we return the relative path as JSON.
Please make sure to replace "~/uploads/" with the actual path where you want to save the files on your server. Also, ensure that the server has the necessary write permissions to that directory.

Remember, this is a basic example and doesn’t include error handling and file validation (like checking file size, file type etc.) which you should implement in a production environment.

Thanks
+2